Enhance load schema with filtering#663
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional filtering and normalization capabilities to pkg/table’s schema loader so callers can exclude internal/archived tables and remove volatile AUTO_INCREMENT table options when retrieving SHOW CREATE TABLE output.
Changes:
- Introduces
FilterOptionsto control underscore-table exclusion, archive-table exclusion, andAUTO_INCREMENTstripping. - Updates
LoadSchemaFromDBto accept optional filtering/transform behavior via variadic options. - Adds integration tests covering each filter/transform option and a combined scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/table/table_schema.go | Adds filter options, regex helpers, and applies filtering/DDL transformation during schema load. |
| pkg/table/table_schema_test.go | Adds MySQL-backed tests to validate filtering and AUTO_INCREMENT stripping behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aparajon
reviewed
Mar 17, 2026
aparajon
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
This adds optional filtering to the LoadSchemaFromDB API. We are always filtering out the same things in our downstream API usage, so it makes sense to push it into here.