tableinfo: replace QuotedName with QuotedTableName, fix force-kill and test helpers#681
Merged
Merged
Conversation
…d test helpers
Three related changes to support N:M moves where connections are scoped
to specific databases:
1. TableInfo: replace QuotedName (`schema`.`table`) with
QuotedTableName (`table`). All SQL statements now use the
unqualified table name since connections are already scoped to the
correct database via DSN. Updated all production code and tests.
2. force-kill (dbconn/kill.go): use DATABASE() instead of parameterized
schema name in performance_schema queries. This resolves the schema
at query time from the connection, so force-kill works correctly
regardless of what SchemaName is set on the TableInfo.
3. CreateUniqueTestDatabase: now returns (string, *sql.DB) instead of
just string. The returned *sql.DB is scoped to the new database,
fixing tests that previously used a connection scoped to 'test' with
TableInfo objects pointing to a different database.
4. migration/runner.go: don't override LockWaitTimeout default when
the Migration struct has the zero value (fixes test failures when
constructing Migration{} without Kong parsing).
morgo
force-pushed
the
quoted-tablename-and-forcekill
branch
from
c3e7f99 to
3001db2
Compare
aparajon
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related changes to support N:M moves where connections are scoped to specific databases:
TableInfo: replace QuotedName (
schema.table) with QuotedTableName (table). All SQL statements now use the unqualified table name since connections are already scoped to the correct database via DSN. Updated all production code and tests.force-kill (dbconn/kill.go): use DATABASE() instead of parameterized schema name in performance_schema queries. This resolves the schema at query time from the connection, so force-kill works correctly regardless of what SchemaName is set on the TableInfo.
CreateUniqueTestDatabase: now returns (string, *sql.DB) instead of just string. The returned *sql.DB is scoped to the new database, fixing tests that previously used a connection scoped to 'test' with TableInfo objects pointing to a different database.
migration/runner.go: don't override LockWaitTimeout default when the Migration struct has the zero value (fixes test failures when constructing Migration{} without Kong parsing).