test(#782): migrate pkg/statement tests to require.*#800
Merged
morgo merged 5 commits intoMay 3, 2026
Conversation
Part of block#779. Setup-path errors now fail-fast instead of cascading into confusing follow-on assertion failures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…riven loops keep assert Per block#779 follow-up: assert.* is now allowed ONLY inside goroutine bodies (where require.FailNow is unsafe) and inside table-driven test loops (where seeing all case failures together helps). Everything else uses require.*. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aparajon
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #782. Part of #779.
Summary
assert.*→require.*inpkg/statement/*_test.gowhere appropriate.assert.*where seeing all failures at once is preferable.Test plan
🤖 Generated with Claude Code