Skip to content

[codex] Add workflow UI parity#250

Merged
wesbillman merged 1 commit intomainfrom
codex/workflow-ui-parity
Apr 6, 2026
Merged

[codex] Add workflow UI parity#250
wesbillman merged 1 commit intomainfrom
codex/workflow-ui-parity

Conversation

@wesbillman
Copy link
Copy Markdown
Collaborator

Summary

  • add desktop workflow builder parity for backend-supported workflow schema fields
  • surface workflow metadata in the list/detail UI, including enabled state, descriptions, and trigger summaries
  • show webhook URL/secret details after save and warn in the UI about backend workflow actions that are still stubbed or context-sensitive

Why

The workflow engine supports fields and trigger types that the desktop app was not exposing, which made the frontend lag behind the backend and hid real execution caveats from users.

Impact

Channel workflow authors can now create and edit more of the workflow definition directly from the desktop app, and they get clearer feedback about current backend gaps like approval gates and manual/webhook channel requirements.

Validation

  • cd desktop && pnpm check
  • cd desktop && pnpm build
  • cd desktop && pnpm exec playwright test tests/e2e/workflows.spec.ts
  • cargo check --manifest-path desktop/src-tauri/Cargo.toml
  • pre-push hooks: desktop check, desktop build, desktop Tauri check, workspace clippy, and unit tests

@wesbillman wesbillman marked this pull request as ready for review April 6, 2026 18:20
@wesbillman
Copy link
Copy Markdown
Collaborator Author

@codex please review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3bfea44554

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +39 to +41
{
id: `${stepId}_header_${currentHeaders.length + 1}`,
key: "",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Generate unique header row IDs

This ID is derived from currentHeaders.length + 1, which can repeat after deletions (for example, remove one row, then add another). Because rows are rendered with key={header.id}, duplicate IDs produce duplicate React keys, leading to unstable list reconciliation and header inputs that can behave unpredictably. Use a monotonic counter or UUID-based ID instead of a length-based suffix.

Useful? React with 👍 / 👎.

Comment on lines +33 to +34
This secret is only shown now. If it is lost, re-save the workflow
to generate a new one.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fix webhook secret recovery instructions

The dialog says users can re-save to generate a new secret, but the backend preserves an existing webhook secret on update and only returns webhook_secret when none existed before (see update_workflow and ensure_webhook_secret in the relay API). If a user loses the secret, this guidance sends them down a path that will not recover it, which is especially problematic because the secret is intentionally shown only once.

Useful? React with 👍 / 👎.

@wesbillman wesbillman merged commit c0421a5 into main Apr 6, 2026
8 checks passed
@wesbillman wesbillman deleted the codex/workflow-ui-parity branch April 6, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant