Skip to content

Replace inline channel creation with dialog#312

Merged
wesbillman merged 3 commits intomainfrom
devin/create-channel-dialog
Apr 13, 2026
Merged

Replace inline channel creation with dialog#312
wesbillman merged 3 commits intomainfrom
devin/create-channel-dialog

Conversation

@wesbillman
Copy link
Copy Markdown
Collaborator

Summary

  • Replaces the inline sidebar channel/forum creation forms with a proper CreateChannelDialog component featuring header, description fields, visibility/ephemeral checkboxes, and cancel/create actions
  • Simplifies AppSidebar significantly (~370 lines removed) by removing inline form code and useCreateForm hook
  • Updates all 4 E2E test files for the new dialog flow
  • Fixes unused ManagedAgentSummary import warning

Test plan

  • Verify creating a stream channel via the new dialog works end-to-end
  • Verify creating a forum via the new dialog works end-to-end
  • Verify private and ephemeral toggles function correctly
  • Run E2E test suite to confirm updated tests pass

🤖 Generated with Claude Code

wesbillman and others added 3 commits April 13, 2026 16:20
Move channel/forum creation from cramped inline sidebar forms to a proper
dialog with header, description, labeled fields, and a footer. Add an
optional agent picker so users can invite managed agents at creation time.

- New CreateChannelDialog component reuses existing Radix Dialog primitives
- AppSidebar simplified: removed useCreateForm hook and inline form rendering
- AppShell updated to pass agentPubkeys through and call addChannelMembers
- All E2E tests updated to match new dialog test IDs and flow

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The agent picker needs more design thought before shipping. Strip
the AgentPicker component, agent-related state, and addChannelMembers
plumbing from the create-channel flow.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@wesbillman wesbillman merged commit 423ed01 into main Apr 13, 2026
10 checks passed
@wesbillman wesbillman deleted the devin/create-channel-dialog branch April 13, 2026 22:58
tellaho added a commit that referenced this pull request Apr 14, 2026
* origin/main:
  Replace inline channel creation with dialog (#312)
  chore: improve chat message layout to left-aligned design (#309)
  Add edit dialog for managed agents with relay profile sync (#277)
  fix(ci): build relay with optimized profile to fix flaky e2e tests (#307)
  Update actions/checkout action to v6 (#305)
  Update dependency @tanstack/react-query to v5.98.0 (#304)
  Update dependency @playwright/test to v1.59.1 (#303)
  Update react monorepo to v19.2.5 (#302)
  feat(mobile): scaffold Flutter app with Riverpod & Catppuccin theme (#306)
  Update dependency @tanstack/react-router to v1.168.13 (#301)
  feat: Markdown-based persona packs (crate + ACP + desktop) (#297)
  feat(desktop): improve Agents page UX (#298)
  feat(desktop): add Pulse social notes surface (#296)
  Fix flaky desktop smoke tests (#294)
  Add agent lifecycle controls to channel members sidebar (#291)

# Conflicts:
#	desktop/pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant