chore: fix deprecation warnings and decompose AgentsView#347
Merged
wesbillman merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
- Replace deprecated rodio DeviceTrait::name() with description().name() across audio_output.rs (3 call sites) - Remove dead tts_cancel field from SttPipeline in stt.rs — the worker thread gets its own Arc clone before storage, so the field was unused - Extract useManagedAgentActions and usePersonaActions hooks from the 825-line AgentsView god component, reducing it to a ~280-line orchestrator that wires hooks to JSX (follows the existing useTeamActions pattern) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tlongwell-block
added a commit
that referenced
this pull request
Apr 17, 2026
* origin/main: nip-ab: clarify transcript_hash role and fix protocol diagram (#346) chore: fix deprecation warnings and decompose AgentsView (#347) chore: improve thread panel inline replies and nesting behavior (#339) feat: NIP-AB device pairing — Phase 2 (desktop + mobile UI) (#343) fix(huddle): prevent phantom huddle from late-arriving relay events (#344) perf(tts): reduce Kokoro time-to-first-audio with session warmup and threading (#342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceTrait::name()with the newdescription().name()API inaudio_output.rstts_cancelfield fromSttPipelineinstt.rs— the worker thread gets its ownArc::clonebefore storage, so the struct field served no purposeuseManagedAgentActionsandusePersonaActionshooks from the 825-line god component, reducing it to a ~280-line orchestrator (follows the existinguseTeamActionspattern)Test plan
cargo check— zero warnings, clean buildcargo test --lib— all 185 Rust tests passnpx tsc --noEmit— zero TypeScript errorspnpm check— biome lint/format cleancargo fmt— clean🤖 Generated with Claude Code