fix(desktop): stop pinning agents to deprecated SPROUT_ACP_TURN_TIMEOUT#592
Merged
Merged
Conversation
The desktop spawn path was always emitting `SPROUT_ACP_TURN_TIMEOUT` (the deprecated knob in sprout-acp) with a hard-coded default of 320s, which overrode the harness's own `DEFAULT_IDLE_TIMEOUT_SECS` (now 620s after PR #566). The visible symptom: agents launched from the desktop kept being killed at exactly 320 seconds even though the harness defaults to 620. Fix: only emit `SPROUT_ACP_IDLE_TIMEOUT` when the agent record has an explicit `idle_timeout_seconds` override. Otherwise, say nothing and let the harness apply its own default — single source of truth. Notes: - The legacy `turn_timeout_seconds` field on the agent record (and its exposure in CreateAgentDialog) is now a dead input on the spawn path. Doc comment on `DEFAULT_AGENT_TURN_TIMEOUT_SECONDS` updated to reflect that. Removing the field entirely is a follow-up (touches DB schema and UI). - No tests assert on the env-var emission; existing managed_agents tests still pass (115/115). Signed-off-by: Tyler Longwell <109685178+tlongwell-block@users.noreply.github.com>
tlongwell-block
added a commit
that referenced
this pull request
May 15, 2026
* origin/main: (33 commits) dev-mcp: add view_image tool (#602) fix(relay,desktop): only advertise NIP-43 when enforced; probe pairing by supported_nips (#601) fix(desktop): derive unread state from NIP-RS + relay catch-up only (#599) docs(testing): rewrite TESTING.md for current API and CLI-first workflow (#597) fix(agent): fix OpenAI-compat request body serialization and max_tokens (#595) feat(desktop): per-persona and per-agent env var overrides (#594) fix(desktop): stop pinning agents to deprecated SPROUT_ACP_TURN_TIMEOUT (#592) fix(desktop): populate member_count in get_channels so channel browser shows real counts (#548) fix(desktop): autofocus message composer on channel/thread open (#572) refactor(cli): restructure flat commands into 12 subcommand groups (#585) feat(sdk): add builder functions for workflows, DMs, and presence (#589) feat(desktop): add message more-actions dropdown menu (#590) fix(mobile): preserve channel list across background/resume reconnection (#588) Redesign Home as an inbox (#582) fix(desktop): drive unread badges from live subscription, not refetched lastMessageAt (#581) fix(desktop): refine header scaling and shadow (#573) fix(desktop): keep day dividers below header (#574) Move agent activity below composer (#579) docs(nips): NIP-AE — Agent Engrams (#575) refactor: extract shared @mention resolver into sprout-sdk (#580) ... Signed-off-by: Tyler Longwell <tlongwell@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Desktop-launched agents were being killed at exactly 320s even after PR #566 raised the sprout-acp idle-timeout default to 620s. The reason: the desktop spawn path always emitted the deprecated
SPROUT_ACP_TURN_TIMEOUTenv var with a hard-coded fallback of 320, which the harness's deprecation handler then used as the effective idle timeout — silently overriding the new default.What
In
desktop/src-tauri/src/managed_agents/runtime.rs, only emitSPROUT_ACP_IDLE_TIMEOUTwhen the agent record has an explicitidle_timeout_secondsoverride. When unset, say nothing and let the harness apply its ownDEFAULT_IDLE_TIMEOUT_SECS(currently 620s).Net: -8 / +3 logic lines, plus a doc-comment refresh on
DEFAULT_AGENT_TURN_TIMEOUT_SECONDS.Effect
idle_timeout_secondsare unchanged.SPROUT_ACP_TURN_TIMEOUTwill stop appearing in desktop agent logs.Notes / Follow-ups
turn_timeout_secondsfield onManagedAgentRecord(and its UI exposure inCreateAgentDialogwith default "320") is now a dead input on the spawn path. Doc comment onDEFAULT_AGENT_TURN_TIMEOUT_SECONDSupdated to reflect that. Removing the field entirely is a separate change — touches DB schema migrations + the dialog UI + the e2e bridge.managed_agentstests pass (115/115).Verification
cargo build --libcleancargo test --lib managed_agents→ 115 passed