Update desktop navigation chrome and search by thomaspblock · Pull Request #779 · block/sprout

thomaspblock · 2026-05-28T21:59:41Z

Summary

Moves search into the global top chrome with inline suggestions, responsive sizing, and Cmd+K focus/open behavior.
Removes the legacy modal search path so the desktop app has one search surface.
Refines desktop header layout for channel, thread, inbox, and agent activity panels so row-two labels and dividers align with the new top chrome.
Moves workspace switching into the profile area and cleans up sidebar/top-right action placement.
Aligns the repo's Hermit pnpm shim with the package manager pin so hooks run consistently.

Test plan

cd desktop && pnpm check
cd desktop && pnpm build && pnpm exec playwright test --project=smoke tests/e2e/smoke.spec.ts
bin/just ci
Pre-commit hooks passed for all commits on this branch.
Pre-push hooks passed when pushing search-middle-description.

Made with Cursor

Move search, workspace switching, and thread controls into the top/profile chrome, including a centered live search variation. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

wesbillman · 2026-05-28T22:11:18Z

@codex please review

thomaspblock · 2026-05-28T22:12:12Z

Search04.mp4

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e82f6b2d00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T22:15:15Z

+      <div className="fixed right-3 top-[9px] z-[80] flex items-center gap-0.5 md:hidden">
+        <Button
+          aria-label="Search everything"
+          className="h-[22px] w-[22px] text-muted-foreground/70 hover:bg-muted/60 hover:text-foreground"
+          data-testid="open-search-compact"
+          onClick={() => onOpenFullSearch()}


Move compact search away from top-right actions

On viewports below the md breakpoint, this fixed compact search button is rendered at right-3 top-[9px] with z-[80], while ChatHeader top-right actions and HomeChannelActions also render their action bars at the same right-3 top-[9px] position with z-[70]. On narrow desktop windows this causes the search button to sit directly over the rightmost channel/home action (for example the manage-channel button), making that action visually overlapped and unclickable; reserve horizontal space or offset one of the fixed groups when the compact search control is visible.

Useful? React with 👍 / 👎.

Align desktop e2e coverage with the updated Home, search, and thread header UI so CI validates the intended layout instead of removed titles. Co-authored-by: Cursor <cursoragent@cursor.com>

Keep the small-screen search control with the left navigation buttons so it does not overlap channel or home action controls. Co-authored-by: Cursor <cursoragent@cursor.com>

Bring in the latest main changes while preserving the desktop Home chrome layout and adopting the new thread activity feed behavior. Co-authored-by: Cursor <cursoragent@cursor.com>

wesbillman · 2026-05-29T01:24:10Z

@thomaspblock I love this approach! Way easier to use!

I noticed a couple small issues on this branch:

On small screens, I think the search can overlap the sidebar, which might be a bit odd

Also CMD+K seems to open the old search experience still even though the hint on the new search is also CMD+K.

This PR should also remove that old search experience to clean up the existing code.

thomaspblock · 2026-05-29T01:27:50Z

yes they are both being fixed (and a few more things) in a fast follow but there were already so many changes I got worried it would be too big. I can add if you want to before we merge or you can merge and ill fix these two based on the new version. You are the expert here I will follow your lead.

Focus Cmd+K on the new topbar search experience and remove the legacy modal search path so the PR has one search surface. Co-authored-by: Cursor <cursoragent@cursor.com>

thomaspblock · 2026-05-29T01:58:35Z

🤖 Updated this PR with the follow-up fixes for the two search comments:

Removed the compact search icon from the left nav cluster and kept drawer/history controls next to the window controls, avoiding the small-screen sidebar overlap.
Routed Cmd+K to the new topbar search, made it open the visible search panel immediately, and removed the legacy modal search implementation.

Also added responsive search widths so it stays compact on smaller windows and expands on larger ones.

wesbillman · 2026-05-29T15:26:24Z

Nice! Fix looks good!

yes they are both being fixed (and a few more things) in a fast follow but there were already so many changes I got worried it would be too big. I can add if you want to before we merge or you can merge and ill fix these two based on the new version. You are the expert here I will follow your lead.

I tend to limit PRs to just one change if possible (but sometimes I just do "polish pass" type PRs). And for that change I just make sure it's not buggy. We release the app constantly, so we have to try to keep it in an always working state. So basically tiny changes that are bug free or at least don't break the experience.

Also, since we're kind of reviewing and merging each other's PR, you can keep the PR in "Draft" until you're ready for eyes/testing on it as well.

thomaspblock and others added 7 commits May 28, 2026 11:06

Update desktop navigation chrome

5f2fcad

Move search, workspace switching, and thread controls into the top/profile chrome, including a centered live search variation. Co-authored-by: Cursor <cursoragent@cursor.com>

Align Hermit pnpm version

f03b6ba

Co-authored-by: Cursor <cursoragent@cursor.com>

Update desktop search and header chrome

8766eb1

Co-authored-by: Cursor <cursoragent@cursor.com>

Merge origin/main into search-middle-description

af67772

Co-authored-by: Cursor <cursoragent@cursor.com>

Adjust desktop header panel spacing

7a1dc12

Co-authored-by: Cursor <cursoragent@cursor.com>

Polish thread panel header divider

ce7f222

Co-authored-by: Cursor <cursoragent@cursor.com>

Align channel title when sidebar collapses

e82f6b2

Co-authored-by: Cursor <cursoragent@cursor.com>

thomaspblock requested a review from a team as a code owner May 28, 2026 21:59

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

thomaspblock and others added 3 commits May 28, 2026 18:40

Update desktop e2e expectations for new chrome

a96a5d6

Align desktop e2e coverage with the updated Home, search, and thread header UI so CI validates the intended layout instead of removed titles. Co-authored-by: Cursor <cursoragent@cursor.com>

Move compact search into navigation chrome

e0c9f9e

Keep the small-screen search control with the left navigation buttons so it does not overlap channel or home action controls. Co-authored-by: Cursor <cursoragent@cursor.com>

Merge main into search-middle-description

0b6ab8c

Bring in the latest main changes while preserving the desktop Home chrome layout and adopting the new thread activity feed behavior. Co-authored-by: Cursor <cursoragent@cursor.com>

Update desktop search shortcut behavior

39d976b

Focus Cmd+K on the new topbar search experience and remove the legacy modal search path so the PR has one search surface. Co-authored-by: Cursor <cursoragent@cursor.com>

wesbillman approved these changes May 29, 2026

View reviewed changes

wesbillman merged commit d77b111 into main May 29, 2026
15 checks passed

wesbillman deleted the search-middle-description branch May 29, 2026 15:26

wesbillman mentioned this pull request May 29, 2026

chore(release): release version 0.3.4 #786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update desktop navigation chrome and search#779

Update desktop navigation chrome and search#779
wesbillman merged 11 commits into
mainfrom
search-middle-description

thomaspblock commented May 28, 2026 •

edited

Loading

Uh oh!

wesbillman commented May 28, 2026

Uh oh!

thomaspblock commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Uh oh!

wesbillman commented May 29, 2026

Uh oh!

thomaspblock commented May 29, 2026

Uh oh!

thomaspblock commented May 29, 2026

Uh oh!

wesbillman commented May 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

thomaspblock commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

wesbillman commented May 28, 2026

Uh oh!

thomaspblock commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

wesbillman commented May 29, 2026

Uh oh!

thomaspblock commented May 29, 2026

Uh oh!

thomaspblock commented May 29, 2026

Uh oh!

wesbillman commented May 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thomaspblock commented May 28, 2026 •

edited

Loading