Skip to content

fix: malformed S3 snapshot file paths that were missing directory separators and filenames#14

Merged
bakayolo merged 1 commit intoblock:mainfrom
Kiran01bm:kiran01bm-fix-s3-snapshots-prefix
Apr 14, 2026
Merged

fix: malformed S3 snapshot file paths that were missing directory separators and filenames#14
bakayolo merged 1 commit intoblock:mainfrom
Kiran01bm:kiran01bm-fix-s3-snapshots-prefix

Conversation

@Kiran01bm
Copy link
Copy Markdown
Contributor

Summary

Fixes malformed S3 snapshot file paths that were missing directory separators and filenames.

Before:
s3://version-guard-findings-stage/snapshots2026/04/14/.json

Screenshot 2026-04-15 at 7 11 40 am

After:
s3://version-guard-findings-stage/snapshots/2026/04/15/{scan-id}.json
s3://version-guard-findings-stage/snapshots/latest.json

Testing

  • All existing tests pass
  • Verified S3 key generation in pkg/snapshot/store.go::generateKey()

Impact

  • Fixes snapshot persistence for production deployments
  • No breaking changes - only affects default configuration
  • Users can still override S3_PREFIX via environment variable

…arators and filenames

Co-authored-by: Claude Code <noreply@anthropic.com>
Ai-assisted: true
@Kiran01bm Kiran01bm requested a review from bakayolo as a code owner April 14, 2026 21:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/workflow/orchestrator/workflow.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
pkg/workflow/orchestrator/workflow.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bakayolo bakayolo merged commit 4924def into block:main Apr 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants