feat(chart): support extraContainers, volumes, and volumeMounts#23
Merged
feat(chart): support extraContainers, volumes, and volumeMounts#23
Conversation
bakayolo
force-pushed
the
feat/chart-extra-containers
branch
2 times, most recently
from
5e9d7ca to
98ad4da
Compare
Allow injecting sidecar containers and volumes via Helm values. Used by the EOL override sidecar (nginx serving patched endoflife.date JSON files for products with pending upstream PRs). Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d98f0-cc82-75bf-b664-e3a63eef6ee9
bakayolo
force-pushed
the
feat/chart-extra-containers
branch
from
98ad4da to
a6118e5
Compare
nandiheath
approved these changes
Apr 17, 2026
nandiheath
left a comment
nandiheath
left a comment
There was a problem hiding this comment.
Looks good! 🤖 Automated review passed — no blockers found.
This was referenced Apr 17, 2026
bakayolo
added a commit
that referenced
this pull request
Apr 18, 2026
…ns (#25) ## Problem 1. Helm chart was published on every tagged release, even when only app code changed 2. Chart.yaml version could collide with an existing git tag (e.g., v0.3.0 was already tagged when PR #23 set chart version to 0.3.0) ## Fix - **Skip publish**: diff `charts/` against the previous tag — only publish if chart files changed - **PR guard**: fail CI if `Chart.yaml` version matches an existing git tag, catching collisions before merge Co-authored-by: Amp <amp@ampcode.com>
bakayolo
added a commit
that referenced
this pull request
Apr 18, 2026
Bump chart version to 0.4.0 to include extraContainers/volumes support (PR #23). Tag v0.3.0 was already taken by a prior release. Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
extraContainers,volumes, andvolumeMountssupport to the Helm deployment template.Used by the EOL override sidecar — an nginx container serving patched endoflife.date JSON files for products with pending upstream PRs (aurora-mysql, opensearch 3.3/3.5).
Changes
charts/version-guard/templates/deployment.yaml— adds optionalextraContainers,volumes, andvolumeMountsblocks from values.Usage