correctness: validate WT_*_BASE config paths are absolute paths#26
Merged
guodong-sq merged 1 commit intoblock:mainfrom Mar 9, 2026
Merged
Conversation
Config path variables (WT_MAIN_REPO_ROOT, WT_WORKTREES_BASE, WT_IDEA_FILES_BASE) are now validated on every bin/wt-* invocation. Relative paths and glob characters are rejected with actionable error messages pointing to the config file or git config to fix. This prevents subtle bugs where relative paths silently resolve against whatever CWD the script happens to run from, producing unpredictable worktree locations or metadata vault paths. Globs could cause unexpected shell expansion in find/for loops. Shell startup (source wt.sh) is never affected — validation only runs in bin/wt-* scripts. wt-context is exempt so users can fix bad config.
guodong-sq
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config path variables (WT_MAIN_REPO_ROOT, WT_WORKTREES_BASE, WT_IDEA_FILES_BASE) are now validated on every bin/wt-* invocation. Relative paths and glob characters are rejected with actionable error messages pointing to the config file or git config to fix.
This prevents subtle bugs where relative paths silently resolve against whatever CWD the script happens to run from, producing unpredictable worktree locations or metadata vault paths.
Globs could cause unexpected shell expansion in find/for loops.
Shell startup (source wt.sh) is never affected — validation only runs in bin/wt-* scripts. wt-context is exempt so users can fix bad config.
Validate instead of fix
To avoid making assumptions about relative paths that may produce surprising behavior under certain circumstances, we should just validate & make our expectations clear and leave it to the user to fix their config.