fix: settings Apply/OK buttons not saving changes#31
Merged
guodong-sq merged 3 commits intomainfrom Mar 10, 2026
Merged
Conversation
Bind checkboxes directly to settings.state properties and delegate isModified/apply/reset to DialogPanel. The previous approach used intermediate local fields that were never updated by the UI bindings, so isModified() always returned false. Co-authored-by: Claude Code <noreply@anthropic.com> Ai-assisted: true
Push a tag like `plugin-v0.1.0` to build the plugin, run tests, and create a GitHub release with the installable ZIP artifact. Co-authored-by: Claude Code <noreply@anthropic.com> Ai-assisted: true
This reverts commit 0128706. Co-authored-by: Claude Code <noreply@anthropic.com> Ai-assisted: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bindSelected(::localField)binds to local Kotlin properties, but the UI DSL only writes to them whenpanel.apply()is called —isModified()compared never-updated local fields against settings, always returning falsesettings.state::propertyand delegateisModified()/apply()/reset()toDialogPanel