Add SSZ Poseidon2 wrapper and document SSZ usage #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch4r10t33r
reviewed
Jan 20, 2026
Collaborator
ch4r10t33r
left a comment
ch4r10t33r
left a comment
There was a problem hiding this comment.
Have validated if the cross language tests are working correctly post this change? Please test this for all lifetimes (2^8, 2^18 and 2^32) with number of active epochs as 256/1024.
ch4r10t33r
requested changes
Jan 20, 2026
| /// so we buffer until we have enough data. | ||
| pub fn update(self: *Self, data: []const u8) void { | ||
| // Enforce the 64-byte limit explicitly | ||
| std.debug.assert(self.buffer_len + data.len <= BUFFER_SIZE); |
Collaborator
There was a problem hiding this comment.
in release builds, this will be ignored, which can still lead to uncaught overflow issues. Can we please replace this with runtime checks?
Something like
if (self.buffer_len + data.len > BUFFER_SIZE) {
@panic("Input exceeds 64-byte SSZ compression limit");
}
|
|
||
| /// Finalize the hash and write the result to out | ||
| pub fn final(self: *Self, out: []u8) void { | ||
| std.debug.assert(out.len == 32); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
hash_zig.ssz.SszHasher(Poseidon2‑24) and runs Plonky3 parity tests.NOTE: version bump post‑merge