Skip to content

fix: add --data-dir flag to ethlambda#167

Merged
ch4r10t33r merged 3 commits intoblockblaz:mainfrom
lambdaclass:add-data-dir-to-ethlambda
Apr 27, 2026
Merged

fix: add --data-dir flag to ethlambda#167
ch4r10t33r merged 3 commits intoblockblaz:mainfrom
lambdaclass:add-data-dir-to-ethlambda

Conversation

@MegaRedHand
Copy link
Copy Markdown
Contributor

We added a --data-dir flag to ethlambda, but lean-quickstart isn't using it.

This PR adds the flag to ethlambda-cmd.sh, so the node data is stored in the right place. Also removes a .DS_Store file that was in the repo.

Copilot AI review requested due to automatic review settings April 27, 2026 15:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates lean-quickstart’s Ethlambda client launcher to pass the newly supported --data-dir flag so Ethlambda stores its node data under the expected per-node data directory, and removes an accidentally committed macOS metadata file.

Changes:

  • Add --data-dir to Ethlambda binary invocation ($dataDir/$item) so per-node data is written to the correct location.
  • Add --data-dir /data to Ethlambda docker invocation to align with the existing /data volume mount.
  • Remove the tracked .DS_Store file from the repo.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
client-cmds/ethlambda-cmd.sh Passes --data-dir for both binary and docker execution so Ethlambda writes data to the intended directory.
.DS_Store Removes an accidentally committed macOS Finder metadata file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MegaRedHand you will need to add the same configuration to ansible/roles/ethlambda/tasks/main.yml. I am working on some improvements, which will remove such duplicate code, but that is likely to be completed a bit later. So for now can you please add the same change in that file as well?

@MegaRedHand
Copy link
Copy Markdown
Contributor Author

@ch4r10t33r Done in 6ffa260

Copy link
Copy Markdown
Contributor

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ch4r10t33r ch4r10t33r merged commit e2ce77b into blockblaz:main Apr 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants