chore: update ethlambda CLI flags to align with the spec#168
Open
conache wants to merge 2 commits intoblockblaz:mainfrom
Open
chore: update ethlambda CLI flags to align with the spec#168conache wants to merge 2 commits intoblockblaz:mainfrom
conache wants to merge 2 commits intoblockblaz:mainfrom
Conversation
Contributor
|
|
conache
changed the title
Author
@MegaRedHand thanks for flagging this! Updated in 7e7e5f4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns ethlambda's CLI flags with the client cli flags spec.
Changes:
In
client-cmds/ethlambda-cmd.sh, both thenode_binaryandnode_dockerinvocations now pass the following flags instead of the single--custom-network-config-dir:--genesis<config_dir>/config.yaml--validators<config_dir>/annotated_validators.yaml--bootnodes<config_dir>/nodes.yaml--validator-config<config_dir>/validator-config.yaml--hash-sig-keys-dir<config_dir>/hash-sig-keys<config_dir>is$configDirin binary mode and/configin docker mode.Note: ethlambda flags PR will be merged once this PR is approved, as stated in @MegaRedHand's comment here.