docker: download the zig compiler for the right target#105
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Docker build process to properly support multi-architecture builds by downloading the correct Zig compiler for each target architecture and copying the appropriate runtime libraries. The change addresses an issue where the ARM build was downloading the wrong compiler architecture.
- Replaces hardcoded x86_64 Zig compiler download with architecture-aware logic
- Adds runtime library selection based on target architecture
- Introduces an intermediate runtime-prep stage to handle architecture-specific library copying
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arm build was reactivated, and the error from risc0 circumvented. But it was downloading the compiler in a way that