Skip to content

docker: download the zig compiler for the right target#105

Merged
gballet merged 1 commit intomainfrom
fix-arm64-docker-compiler-arch
Aug 27, 2025
Merged

docker: download the zig compiler for the right target#105
gballet merged 1 commit intomainfrom
fix-arm64-docker-compiler-arch

Conversation

@gballet
Copy link
Copy Markdown
Contributor

@gballet gballet commented Aug 27, 2025

The arm build was reactivated, and the error from risc0 circumvented. But it was downloading the compiler in a way that

Copilot AI review requested due to automatic review settings August 27, 2025 08:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the Docker build process to properly support multi-architecture builds by downloading the correct Zig compiler for each target architecture and copying the appropriate runtime libraries. The change addresses an issue where the ARM build was downloading the wrong compiler architecture.

  • Replaces hardcoded x86_64 Zig compiler download with architecture-aware logic
  • Adds runtime library selection based on target architecture
  • Introduces an intermediate runtime-prep stage to handle architecture-specific library copying

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gemini-code-assist
Copy link
Copy Markdown

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@gballet gballet merged commit b74633d into main Aug 27, 2025
5 checks passed
@gballet gballet deleted the fix-arm64-docker-compiler-arch branch August 27, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants