Conversation
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
g11tech
reviewed
Apr 20, 2025
|
|
||
| // add state transition, create a new module for each zkvm since | ||
| // that module depends on the zkvm module. | ||
| const zeam_state_transition = b.addModule("@zeam/state-transition", .{ |
Member
There was a problem hiding this comment.
can't we only add the zkvm addImport to this module inside the loop and else keep it outside the loop?
Contributor
Author
There was a problem hiding this comment.
no because the module itself is different for each zkvm binary, the import is a reference to the module so we can't do that afaik.
g11tech
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std.debut.printwill not work in a zkvm context, as there is no unix support in these environments. I have created alogfunction that behaves like it, and uses eitherzkvm.io.print_strorstd.debug.printdepending on the context it's run in.Note that it will only be able to print a maximum of 512 characters at a time, but that is good enough for our current use case.