Merged
Conversation
gballet
reviewed
Mar 20, 2025
Comment on lines
+15
to
+19
| const mutex = Mutex{}; | ||
|
|
||
| return Self{ | ||
| .loop = loop, | ||
| .mutex = mutex, |
Contributor
There was a problem hiding this comment.
Suggested change
| const mutex = Mutex{}; | |
| return Self{ | |
| .loop = loop, | |
| .mutex = mutex, | |
| return Self{ | |
| .loop = loop, | |
| .mutex = Mutex{}, |
Contributor
There was a problem hiding this comment.
You are creating an object and copying it. Not a performance hit, but let's remove copies where we can.
Member
Author
There was a problem hiding this comment.
what is the better pattren, i don't want to maintain the pointer/reference in the main eventloop struct?
Contributor
There was a problem hiding this comment.
there's no pointer here, and they are equivalent. It's just saving one line of code and a copy (that is probably not happening anyway as I'm sure the compiler gets rid of it for us)
gballet
added a commit
that referenced
this pull request
Aug 8, 2025
Fixes #8 Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add clock to primarily drive the client via libxev event loop
test usage:
zeam clock