Typos#136
Merged
CJentzsch merged 2 commits intoblockchainsllc:masterfrom Apr 28, 2016
Merged
Conversation
|
|
||
| // If the curator removed the recipient from the whitelist, close the proposal | ||
| // in order to free the deposit and allow unblocking of voters | ||
| if (!isRecipientAllowed(p.recipient) && p.open) { |
Contributor
There was a problem hiding this comment.
that's not a typo ;-)
It saves gas to check it here, compared to later.
Contributor
Author
There was a problem hiding this comment.
It's already checked on line 524.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small obvious fixes.