This repository was archived by the owner on Feb 20, 2021. It is now read-only.
replaced 'request-js' to 'superagent' lib#21
Closed
MaxFrolov wants to merge 1 commit intoblockcypher:masterfrom
Closed
replaced 'request-js' to 'superagent' lib#21MaxFrolov wants to merge 1 commit intoblockcypher:masterfrom
MaxFrolov wants to merge 1 commit intoblockcypher:masterfrom
Conversation
MaxFrolov
force-pushed
the
replace-request-js-to-superagent-lib
branch
from
08564bb to
0a4d015
Compare
Contributor
|
Thanks. Implemented in #36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected: the library can be used in the browser
dependency 'request.js' can be used only on the back-end side without issues, by replacing 'request.js' to 'superagent' we have achieved that 'blockcypher' can be used in both server and browser