Add ability to set mining fee in forwarding address#24
Merged
matthieu merged 7 commits intoblockcypher:masterfrom Jul 20, 2017
Merged
Add ability to set mining fee in forwarding address#24matthieu merged 7 commits intoblockcypher:masterfrom
matthieu merged 7 commits intoblockcypher:masterfrom
Conversation
This fixes the rate limit issue
Still need to figure out a way to credit an address before spending from it, to get those tests to pass as well
Contributor
Author
|
Does this sound like something that's worth merging? |
Contributor
|
Yes it does. Do you have updates you'd like to do to the pull request or is it good as-is? |
Contributor
Author
|
I think this is fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to clean up specs but couldn't get all passing.
Most, if not all, of the failing specs are due to the input address not having enough credit. We could potentially just require the developer to add funds to the input address, and allow them to set the input address that they are to use.