fix: align tx evaluate fixtures with Conway-only platform behavior#65
Merged
vladimirvolek merged 2 commits intomainfrom Apr 13, 2026
Merged
fix: align tx evaluate fixtures with Conway-only platform behavior#65vladimirvolek merged 2 commits intomainfrom
vladimirvolek merged 2 commits intomainfrom
Conversation
michalrus
reviewed
Apr 7, 2026
Member
michalrus
left a comment
There was a problem hiding this comment.
But won’t this break other places that blockfrost-tests are used in? 👀
Member
https://github.com/blockfrost/blockfrost-tests-internal/actions/runs/24073289428 |
567e24a to
b48c0c1
Compare
Contributor
Author
|
Yes, it will break of course. |
b48c0c1 to
b7b4253
Compare
This was referenced Apr 10, 2026
vladimirvolek
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixture Changes for Conway-only Deserialization
Background
blockfrost-platformusespallasdecoding andtestgen-hswithcardano-ledger's Conway decoder both. Both decodes onlyconway.Rust's
pallasproduces different error strings than Haskell'scardano-ledgerfor the same invalid CBOR input.The test CBOR in
txs-evaluate-utxoscontains an emptyrequired_signersfield (CBOR key 14 =0x80). Conway'sfieldGuardedvalidation rejects empty sets that are present rather than omitted. Ogmios avoids this via Babbage fallback, so the transaction never reaches evaluation. Platform behavior depends on which decoder is in use.Below brief explanation of what tests did change:
Preview (
src/fixtures/preview/utils/)txs-evaluate.ts
fails (client fault) to submit on ill-formed tx'...DeserialiseFailure 0 "expected tag".'stringContaining('...CBOR failed with error:')txs-evaluate-utxos.ts
error Unknown transaction input (missing from UTxO set)responseobject asserting a singlejsonwsp/responsewith nestedEvaluationFailure.ScriptFailurescustomExpectfunction that handles two possible outcomes:jsonwsp/responsepath: asserts exact error string including tx input hash via.toBe('Unknown transaction input (missing from UTxO set): 7d67...eb6b#0')jsonwsp/faultpath: assertsresponse.fault.stringcontains'Required Signer Hashes'fieldGuardedrejects the emptyrequired_signersset before evaluation, returning ajsonwsp/fault. Ogmios decodes via Babbage and reaches evaluation, returning ajsonwsp/response. The test now accepts both paths depending on the platform's decoder.Preprod (
src/fixtures/preprod/utils/)txs-evaluate.ts
Same change as preview
txs-evaluate.ts.txs-evaluate-utxos.ts
Same change as preview
txs-evaluate-utxos.ts.