Skip to content

feat(dashboard): migrate dao-overview to kubb-generated REST SDK#1945

Merged
pikonha merged 7 commits into
devfrom
feat/dao-overview-kubb-integration
May 28, 2026
Merged

feat(dashboard): migrate dao-overview to kubb-generated REST SDK#1945
pikonha merged 7 commits into
devfrom
feat/dao-overview-kubb-integration

Conversation

@brunod-e
Copy link
Copy Markdown
Collaborator

Summary

  • Migrates dao-overview hooks (useDaoOverviewData, useDaoTreasuryStats, useQuorumGap) off @anticapture/graphql-client onto the kubb-generated REST SDK (@anticapture/client).
  • Drops 4 thin shared wrappers: useDaoData, useTokenData, useActiveSupply, useAverageTurnout. Every remaining consumer now calls the kubb hooks directly.
  • Keeps wrappers that encode real logic: useTreasury (3-endpoint switch), useQuorumGap (derived math), useDelegates (activity side-fetch).
  • Deletes unused useCompareTreasury wrapper (zero consumers).
  • Includes cherry-pick of feat: migrate attack-profitability hooks to kubb-generated REST SDK #1941 (attack-profitability migration) so useDaoTreasuryStats consumes the kubb-shaped useTreasury.

Out of scope (follow-ups)

  • API aggregations (e.g. `/:dao/quorum-gap`, `/:dao/overview-header`) — deferred.
  • Remaining graphql-client shared hooks not consumed by dao-overview (`useDelegatedSupply`, `useDelegationPercentageByDay`, `useTimeSeriesData`, `useVotes`, `useTokenInfo`, `useLastUpdate`, `useConnectedWalletVotingPower`).
  • Supersedes 86agzktge: Migrate Overview to Kubb SDK #1933.

Test plan

  • `pnpm dashboard typecheck`
  • `pnpm dashboard lint`
  • `pnpm dashboard test` (138/138)
  • Manual smoke: /uni, /ens, /optimism overview pages — header metrics, top-accounts charts, last proposals, active-tokens cell

brunod-e added 2 commits May 27, 2026 13:39
Replace GraphQL client calls with @anticapture/client/hooks across
dao-overview and its dependencies. Drop four thin shared wrappers
(useDaoData, useTokenData, useActiveSupply, useAverageTurnout) and
migrate every remaining consumer to call the kubb hooks directly.
Keep wrappers that encode logic (useTreasury, useQuorumGap, useDelegates).
Delete the unused useCompareTreasury wrapper.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
anticapture Ready Ready Preview, Comment May 28, 2026 8:50pm
anticapture-storybook Ready Ready Preview, Comment May 28, 2026 8:50pm

Request Review

@brunod-e brunod-e changed the base branch from main to dev May 27, 2026 17:01
@brunod-e brunod-e changed the base branch from dev to feat/dev-719-attack-profitability-kubb May 27, 2026 17:04
@railway-app railway-app Bot temporarily deployed to anticapture-infra / anticapture-pr-1945 May 27, 2026 17:06 Destroyed
@railway-app
Copy link
Copy Markdown

railway-app Bot commented May 27, 2026

🚅 Deployed to the anticapture-pr-1945 environment in anticapture-infra

Service Status Web Updated (UTC)
otelcol ✅ Success (View Logs) May 28, 2026 at 8:49 pm
prometheus ✅ Success (View Logs) Web May 28, 2026 at 8:49 pm
loki ✅ Success (View Logs) Web May 28, 2026 at 8:49 pm
tempo ✅ Success (View Logs) May 28, 2026 at 8:49 pm
anticapture-mcp-server ✅ Success (View Logs) Web May 28, 2026 at 8:49 pm
alertmanager ✅ Success (View Logs) Web May 28, 2026 at 8:49 pm
grafana ⏭️ Skipped (View Logs) Web May 28, 2026 at 8:49 pm
fluid-indexer ⏭️ Skipped (View Logs) May 28, 2026 at 8:49 pm
api-gateway ⏭️ Skipped (View Logs) Web May 28, 2026 at 8:49 pm
gitcoin-indexer-offchain ⏭️ Skipped (View Logs) May 28, 2026 at 8:49 pm
uniswap-indexer-offchain ⏭️ Skipped (View Logs) May 28, 2026 at 8:49 pm
gateful ⏭️ Skipped (View Logs) Web May 28, 2026 at 8:49 pm
compound-indexer-offchain ⏭️ Skipped (View Logs) May 28, 2026 at 8:48 pm
ens-indexer-offchain ⏭️ Skipped (View Logs) May 28, 2026 at 8:48 pm
lil-nouns-indexer ⏭️ Skipped (View Logs) May 28, 2026 at 8:48 pm
obol-api ❌ Build Failed (View Logs) May 28, 2026 at 3:20 pm
uniswap-api ❌ Build Failed (View Logs) May 28, 2026 at 3:19 pm
shutter-api ❌ Build Failed (View Logs) May 28, 2026 at 3:19 pm
fluid-api ❌ Build Failed (View Logs) May 28, 2026 at 3:19 pm
scroll-api ❌ Build Failed (View Logs) May 28, 2026 at 3:19 pm
lil-nouns-api ❌ Build Failed (View Logs) May 28, 2026 at 3:18 pm
compound-api ❌ Build Failed (View Logs) Web May 28, 2026 at 3:18 pm
gitcoin-api ❌ Build Failed (View Logs) May 28, 2026 at 3:17 pm
nouns-api ❌ Build Failed (View Logs) May 28, 2026 at 3:17 pm
ens-api ❌ Build Failed (View Logs) May 28, 2026 at 3:17 pm
aave-api ❌ Build Failed (View Logs) May 28, 2026 at 3:17 pm
shutter-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
aave-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
ens-relayer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
ens-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
obol-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
uniswap-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
compound-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
gitcoin-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
scroll-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
address-enrichment ✅ Success (View Logs) Web May 27, 2026 at 5:09 pm
nouns-indexer ✅ Success (View Logs) May 27, 2026 at 5:09 pm
erpc ✅ Success (View Logs) May 27, 2026 at 5:08 pm
nodeful ✅ Success (View Logs) May 27, 2026 at 5:08 pm
16 services not affected by this PR
  • dispatcher
  • uniswap-indexer-offchain
  • RabbitMQ Web UI
  • telegram-bot-db
  • subscription-server
  • RabbitMQ
  • logic-system
  • hyperindex-database
  • hyperindex-erpc
  • grafana
  • consumer
  • ens-indexer-offchain
  • lil-nouns-indexer
  • compound-indexer-offchain
  • fluid-indexer
  • gitcoin-indexer-offchain

@brunod-e brunod-e marked this pull request as ready for review May 28, 2026 15:06
brunod-e added 2 commits May 28, 2026 12:20
Replace GraphQL client calls with @anticapture/client/hooks across
dao-overview and its dependencies. Drop four thin shared wrappers
(useDaoData, useTokenData, useActiveSupply, useAverageTurnout) and
migrate every remaining consumer to call the kubb hooks directly.
Keep wrappers that encode logic (useTreasury, useQuorumGap, useDelegates).
Delete the unused useCompareTreasury wrapper.
Base automatically changed from feat/dev-719-attack-profitability-kubb to dev May 28, 2026 19:06
@railway-app railway-app Bot temporarily deployed to anticapture-infra / anticapture-pr-1945 May 28, 2026 20:48 Destroyed
@pikonha pikonha merged commit fa11db9 into dev May 28, 2026
42 of 43 checks passed
@pikonha pikonha deleted the feat/dao-overview-kubb-integration branch May 28, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants