Skip to content

Refactor/snapshot voting reminder#254

Merged
LeonardoVieira1630 merged 3 commits into
devfrom
refactor/snapshot_voting_reminder
May 12, 2026
Merged

Refactor/snapshot voting reminder#254
LeonardoVieira1630 merged 3 commits into
devfrom
refactor/snapshot_voting_reminder

Conversation

@LeonardoVieira1630
Copy link
Copy Markdown
Member

@LeonardoVieira1630 LeonardoVieira1630 commented May 11, 2026

Summary

Moves the Snapshot (off-chain) voting reminder from the 75-80% elapsed-time window down to the 50-55% window so users are notified earlier — roughly at the midpoint of a proposal — leaving more room to act before voting closes. Also fixes a missing daoId argument when querying non-voters, and sets a sane default RPC for the consumer container so ENS lookups don't hang against viem's rate-limited public default.

Changes

  • Renamed OffchainVotingReminder75OffchainVotingReminder50 (id offchain-voting-reminder-75offchain-voting-reminder-50) in packages/messages/src/notification-types.ts.
  • Reconfigured the off-chain voting reminder trigger in apps/logic-system/src/app.ts to fire at the 50% threshold (5% window unchanged).
  • Updated the dispatcher handler registration in apps/dispatcher/src/app.ts to bind the new OffchainVotingReminder50 notification type, and wired the daoId argument through offchainNonVotersSource.getNonVoters to anticaptureClient.getOffchainProposalNonVoters.
  • Extended AnticaptureClient.getOffchainProposalNonVoters (and regenerated dist) to require daoId so the underlying GraphQL request can target the correct DAO context.
  • Rewrote the integration tests in apps/integrated-tests/tests/telegram/offchain-voting-reminder-trigger.test.ts for the 50-55% window (52% positive case, 40% below-threshold, 60% above-window).
  • Added a default RPC_URL (https://ethereum-rpc.publicnode.com, overridable via env) to the consumers service in docker-compose.yml to prevent the ENS resolver from hanging on viem's rate-limited default RPC.

@LeonardoVieira1630 LeonardoVieira1630 self-assigned this May 11, 2026
@LeonardoVieira1630 LeonardoVieira1630 added the bug Something isn't working label May 11, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flow-editor Ready Ready Preview, Comment May 11, 2026 5:23pm
notification-system-dashboard Ready Ready Preview, Comment May 11, 2026 5:23pm

Request Review

@LeonardoVieira1630 LeonardoVieira1630 merged commit cd2c629 into dev May 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants