Skip to content

Add vaping list#384

Merged
blocklistproject merged 5 commits intoblocklistproject:masterfrom
iam-py-test:master
Jul 7, 2021
Merged

Add vaping list#384
blocklistproject merged 5 commits intoblocklistproject:masterfrom
iam-py-test:master

Conversation

@iam-py-test
Copy link
Copy Markdown
Contributor

@iam-py-test iam-py-test commented Jul 6, 2021

Summary

This PR adds the vaping list, as requested in #308
When merged, this will fix #383

Checklist

  • I have verified that I have not modified any files inside the alt-version folder (automated code will automatically update those files)

  • I have verified that I have not modified any files inside the dnsmasq-version folder (automated code will automatically update those files)

Copy link
Copy Markdown
Collaborator

@fishcharlie fishcharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to say, so far this looks great!

@iam-py-test iam-py-test marked this pull request as ready for review July 6, 2021 21:08
Copy link
Copy Markdown
Collaborator

@fishcharlie fishcharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great. Approving this PR on my end.

Gonna wait until @blocklistproject reviews it as well before merging.

@blocklistproject
Copy link
Copy Markdown
Owner

Are we creating this list to block information about vaping or the sale of vaping products?

Just wondering what the end result of the list is because we need to be able to articulate this to the community.

@iam-py-test
Copy link
Copy Markdown
Contributor Author

iam-py-test commented Jul 6, 2021

Are we creating this list to block information about vaping or the sale of vaping products?

Just wondering what the end result of the list is because we need to be able to articulate this to the community.

I thought it was just for the promotion of vaping; general information can be helpful (i.e. information of how to talk about vaping, the health affects of it)
I have re-reviewed it and made a few modifications

@iam-py-test iam-py-test requested a review from fishcharlie July 6, 2021 21:26
@blocklistproject
Copy link
Copy Markdown
Owner

I am not opposed to either mission, I just want to make sure I am clear.

@iam-py-test
Copy link
Copy Markdown
Contributor Author

iam-py-test commented Jul 6, 2021

I have reviewed the domains & removed ones that are not promoting vaping
@doni74 which type do you want?

@blocklistproject blocklistproject merged commit be17346 into blocklistproject:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Add request] Vaping domain

3 participants