Merged
Conversation
Change `ApplicationRecord.sanitize_sql_like` to `ActiveRecord::Base.sanitize_sql_like`. The bare `ApplicationRecord` reference was resolving to the host app's class rather than the gem's namespaced `ActiveStorageDB::ApplicationRecord`. Using `ActiveRecord::Base` is correct since `sanitize_sql_like` is defined there and avoids any dependency on the host app's class hierarchy.
Refactor `object_for` so `.annotate(comment)` is always applied, not only when fields is present. Previously, full-file downloads and integrity checks produced unannotated SQL queries, making them harder to trace in production logs.
blocknotes
force-pushed
the
update-db-service
branch
from
a6b3c82 to
935322a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Call sanitize_sql_like on ActiveRecord::Base
Change
ApplicationRecord.sanitize_sql_liketoActiveRecord::Base.sanitize_sql_like. The bareApplicationRecordreference was resolving to the host app's class rather than the gem's namespacedActiveStorageDB::ApplicationRecord. UsingActiveRecord::Baseis correct sincesanitize_sql_likeis defined there and avoids any dependency on the host app's class hierarchy.chore: Apply annotate properly inside object_for
Refactor
object_forso.annotate(comment)is always applied, not only when fields is present. Previously, full-file downloads and integrity checks produced unannotated SQL queries, making them harder to trace in production logs.