fix(sequencer): Finally track down stuck transactions#664
Merged
Conversation
What was the problem? === In case a slot contained errors for all feeds from reporters, this lead to a situation where the errors are never cleared in the map of results. Solution === Copy contents of map when populating list of updates. Clear the map, before checking whether the list of updates is empty. Only then, conditionally skip some code, if the list is empty. Before, the clearing step was erroneously skipped, which lead to the bug. Co-authored-by: Hristo Staykov <izo8611@gmail.com> Co-authored-by: Dimo99 <dimodimov1999@gmail.com> Co-authored-by: Antoni Dikov <antoni.dikov@gmail.com>
HristoStaykov
approved these changes
Nov 28, 2024
|
🚀 Deployment Links of Blocksense Network websites: |
Dimo99
approved these changes
Nov 28, 2024
Contributor
Dimo99
left a comment
Dimo99
left a comment
There was a problem hiding this comment.
We should as a test_feed_slots_processor_loop_all_values_are_errors
Contributor
Author
Created issue #665 to track this. |
Contributor
|
Contributor
Author
🤫 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem?
In case a slot contained only errors for all feeds from reporters, this lead to a situation where the errors are never cleared in the map of results.
Solution
Copy contents of map when populating list of updates. Clear the map, before checking whether the list of updates is empty. Only then, conditionally skip some code, if the list is empty.
Before, the clearing step was erroneously skipped, which lead to the bug.