fix: make lookupProfile work with newest stacks API

[pradel]

Description

In the latest version of the SDK, lookupProfile is throwing an error when you call it to query old or new usernames.

I faced this issue when migrating Sigle to the newest SDK version.

• the old SDK version is calling https://core.blockstack.org/v1/names/sigleapp.id.blockstack that returns the address field as a BTC address
• the new SDK version is calling https://stacks-node-api.mainnet.stacks.co/v1/names/sigleapp.id.blockstack returns the address field as a STX address

When you call lookupProfile, internally the verifyProfileToken function is called.
If you take a look here https://github.com/blockstack/stacks.js/blob/626c5fccb4dff213f000923ab69c7ed4f5eb48a0/packages/profile/src/profileTokens.ts#L115-L123
publicKeyOrAddress is the STX address returned by the new API and we compare it with the BTC address that we got from the public key so the check is failing.

For details refer to issue #1016

Type of Change

• New feature
• Bug fix
• API reference/documentation update
• Other

Does this introduce a breaking change?

There is a breaking change in the verifyProfileToken function only if a user uses it directly. By looking at the code it looks like lookupProfile is the only part where it is called.

Testing information

I tested this patch directly into the Sigle codebase and it solved the issue that I am facing.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/stacks-js/8kbDFXR4JabneYXPJLUY4ktbSYwF
✅ Preview: https://stacks-js-git-fork-pradel-feature-fix-lookup-profile-blockstack.vercel.app

[codecov]

Codecov Report

Merging #1028 (c0b5e82) into master (da68307) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
- Coverage   61.10%   61.07%   -0.04%     
==========================================
  Files         101      101              
  Lines        7675     7668       -7     
  Branches     1429     1428       -1     
==========================================
- Hits         4690     4683       -7     
  Misses       2880     2880              
  Partials      105      105              

Impacted Files	Coverage Δ
packages/profile/src/profileTokens.ts	79.66% <100.00%> (-2.16%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da68307...c0b5e82. Read the comment docs.

[reedrosenbluth]

LGTM. Thanks @pradel!

[zone117x]

LGTM, thanks for the fix!!