Skip to content

feat: undo exporting connect from auth - #875

Merged
yknl merged 4 commits into
masterfrom
feat/remove-connect-from-auth
Dec 7, 2020
Merged

feat: undo exporting connect from auth#875
yknl merged 4 commits into
masterfrom
feat/remove-connect-from-auth

Conversation

@yknl

@yknl yknl commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

This PR undos a previous decision to export connect from the auth package in favour of a new structure to be outlined shortly.

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

Yes, tutorials will be updated to reflect new usage.

Are documentation updates required?

Yes

Testing information

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @yknl or @zone117x for review

@kyranjamie kyranjamie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented Dec 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #875 (caa3f80) into master (2db3054) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
- Coverage   76.81%   76.80%   -0.01%     
==========================================
  Files          72       72              
  Lines        4459     4458       -1     
  Branches      751      777      +26     
==========================================
- Hits         3425     3424       -1     
+ Misses        998      997       -1     
- Partials       36       37       +1     
Impacted Files Coverage Δ
src/index.ts 78.30% <0.00%> (-0.21%) ⬇️
src/utils.ts 52.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db3054...caa3f80. Read the comment docs.

@yknl
yknl merged commit 27f9cfb into master Dec 7, 2020
@yknl yknl self-assigned this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants