This repository was archived by the owner on Apr 22, 2026. It is now read-only.
chore: replace blockstack libs with stacks lib, remove pkg keychain - #743
Closed
friedger wants to merge 2 commits into
Closed
chore: replace blockstack libs with stacks lib, remove pkg keychain#743friedger wants to merge 2 commits into
friedger wants to merge 2 commits into
Conversation
5 tasks
Contributor
Author
|
Should be part of https://github.com/blockstack/ux/milestone/30 as it replaces #686 |
Contributor
|
Hmm what's going on with CI, I've not see |
friedger
force-pushed
the
chore/remove_blockstack
branch
from
January 7, 2021 14:47
c36dd9c to
e5975fd
Compare
Contributor
|
Hm, some funky stuff happening with actions. The "Publish npm betas" and "publish firefox beta" aren't supposed to run - the jobs have |
hstove
suggested changes
Jan 8, 2021
hstove
left a comment
hstove
left a comment
Contributor
There was a problem hiding this comment.
There do seem to be a bunch of legit Typescript errors. I would make sure that yarn typecheck works from a clean build (you might need to rebuild node_modules if you can't repro locally).
hstove
force-pushed
the
release/connect-2
branch
3 times, most recently
from
January 9, 2021 20:36
d0d2a9f to
6957c04
Compare
Contributor
|
This is now in #758 , so closing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a developer, I don't want to replace blockstack.js with stacks.js to later learn that I need blockstack.js for @stacks/connect.
This PR
Type of Change
Does this introduce a breaking change?
Developers can remove blockstack as a peer deps from their apps.
Are documentation updates required?
No
Checklist