Skip to content

docs: P13 phase close + phase-close convention (P13f-3)#155

Merged
blokzdev merged 1 commit into
mainfrom
claude/p13f3-phase-close
Jun 5, 2026
Merged

docs: P13 phase close + phase-close convention (P13f-3)#155
blokzdev merged 1 commit into
mainfrom
claude/p13f3-phase-close

Conversation

@blokzdev
Copy link
Copy Markdown
Owner

@blokzdev blokzdev commented Jun 5, 2026

P13f-3 — P13 phase close + the phase-close convention (docs-only)

The final P13 subphase: close out the v1 AI pillar and write down the phase-close convention this session surfaced. No feature code.

The convention (the net-new piece)

Earlier phases left it ambiguous when a [x] ("done & verified on-device") is earned, and P12 flipped its subphases to [x] while the on-device pass was still owed. This PR encodes the tighter, honest rule in CLAUDE.md §7:

  • Marker legend (now canonical in CLAUDE.md): [ ] not started · [~] in progress · [x] done & verified on-device.
  • A (sub)phase earns [x] only when CI is green + exit criteria met + its per-PR APK/on-device spot-check is done. A pure-Dart/UI/docs subphase is CI-dischargeable.
  • Batched on-device checks (CLAUDE.md §6) keep a subphase at [~] — CI-complete but not yet verified — never [x] on the promise of a later check.
  • A top-level phase is closed by one consolidated cross-feature on-device pass in VERIFICATION.md (the holistic gate). Running it discharges the batched per-subphase checks and flips them — and the phase — to [x].

Applying it to P13 (maintainer decisions this session)

  • Nothing reads "done" until that pass runs. P13's APK checks were batched, so the affected subphases stay [~] rather than being flipped to [x].
  • CI-dischargeable exceptions → [x]: P13f-3 (this PR) and P13d-1 (pure-Dart retrieval engine, "CI-covered; no APK check").
  • Honesty fix: the over-claimed P13d parent [x][~] (its children d-2a/d-2b/d-3 are still APK-owed).

Changes

  • docs/VERIFICATION.md — replace the rough "P13 (later subphases)" placeholder with a proper "P13 — consolidated cross-feature on-device pass": the single owed gate, exercising the features together (generation stack on one model · LLM+HNSW RAM co-residency · ML Kit OCR/translate · graph analytics · gating interplay on low-tier · opt-ins persist / offline). The per-subphase rows (a–f) stay as the granular reference.
  • docs/design/P13-PLAN.md — the marker flips above; a P13f-3 Status note; and the ✅ P13 complete placeholder replaced with an honest "code-complete; on-device verification pending" summary.
  • docs/ROADMAP.md — one honest P13 Status line (no premature "done"); date bump.
  • docs/BACKLOG.md — the one missing P13f-2 deferral (unify the translation language name/code sources). All other P13 deferrals were already logged per-subphase.

CI / verification

  • Docs-only; dart format · flutter analyze · flutter test (940) all green locally (confirms no stray Dart change).
  • The single remaining owed item for all of P13 is the maintainer running the consolidated on-device pass, which then flips every P13 marker to [x] and closes the phase (→ P14).

https://claude.ai/code/session_013JoYmLCosYt5tQ8qwdbL1T


Generated by Claude Code

Close out the P13 sub-roadmap (the v1 AI pillar) and encode the
phase-close convention that this session surfaced.

- CLAUDE.md §7: add the canonical status-marker legend + the earned-[x]
  rule (a subphase earns [x] only when its per-PR APK/on-device check is
  done; batched checks keep it [~], not [x]; pure-Dart/UI/docs subphases
  are CI-dischargeable) and the top-level phase-close rule (one
  consolidated cross-feature on-device pass in VERIFICATION.md is the
  holistic gate that flips the batched checks — and the phase — to [x]).
- VERIFICATION.md: replace the rough "P13 (later subphases)" placeholder
  with a proper "P13 — consolidated cross-feature on-device pass" — the
  single owed gate for the whole phase.
- P13-PLAN.md: honest markers — subphases with batched APK checks stay
  [~]; P13f-3 (docs/CI) and P13d-1 (pure-Dart, CI-covered) → [x]; correct
  the over-claimed P13d parent [x]→[~]; replace the "P13 complete"
  placeholder with an honest "code-complete; verification pending" block.
- ROADMAP.md: honest P13 status line (no premature "done"); bump date.
- BACKLOG.md: log the one missing P13f-2 deferral (unify the translation
  language name/code sources).

Docs-only; no code. CI gates green locally (format, analyze, 940 tests).

https://claude.ai/code/session_013JoYmLCosYt5tQ8qwdbL1T
@blokzdev blokzdev merged commit 3ac2270 into main Jun 5, 2026
1 check passed
@blokzdev blokzdev deleted the claude/p13f3-phase-close branch June 5, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants