docs: P13 phase close + phase-close convention (P13f-3)#155
Merged
Conversation
Close out the P13 sub-roadmap (the v1 AI pillar) and encode the phase-close convention that this session surfaced. - CLAUDE.md §7: add the canonical status-marker legend + the earned-[x] rule (a subphase earns [x] only when its per-PR APK/on-device check is done; batched checks keep it [~], not [x]; pure-Dart/UI/docs subphases are CI-dischargeable) and the top-level phase-close rule (one consolidated cross-feature on-device pass in VERIFICATION.md is the holistic gate that flips the batched checks — and the phase — to [x]). - VERIFICATION.md: replace the rough "P13 (later subphases)" placeholder with a proper "P13 — consolidated cross-feature on-device pass" — the single owed gate for the whole phase. - P13-PLAN.md: honest markers — subphases with batched APK checks stay [~]; P13f-3 (docs/CI) and P13d-1 (pure-Dart, CI-covered) → [x]; correct the over-claimed P13d parent [x]→[~]; replace the "P13 complete" placeholder with an honest "code-complete; verification pending" block. - ROADMAP.md: honest P13 status line (no premature "done"); bump date. - BACKLOG.md: log the one missing P13f-2 deferral (unify the translation language name/code sources). Docs-only; no code. CI gates green locally (format, analyze, 940 tests). https://claude.ai/code/session_013JoYmLCosYt5tQ8qwdbL1T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P13f-3 — P13 phase close + the phase-close convention (docs-only)
The final P13 subphase: close out the v1 AI pillar and write down the phase-close convention this session surfaced. No feature code.
The convention (the net-new piece)
Earlier phases left it ambiguous when a
[x]("done & verified on-device") is earned, and P12 flipped its subphases to[x]while the on-device pass was still owed. This PR encodes the tighter, honest rule inCLAUDE.md§7:[ ]not started ·[~]in progress ·[x]done & verified on-device.[x]only when CI is green + exit criteria met + its per-PR APK/on-device spot-check is done. A pure-Dart/UI/docs subphase is CI-dischargeable.[~]— CI-complete but not yet verified — never[x]on the promise of a later check.VERIFICATION.md(the holistic gate). Running it discharges the batched per-subphase checks and flips them — and the phase — to[x].Applying it to P13 (maintainer decisions this session)
[~]rather than being flipped to[x].[x]: P13f-3 (this PR) and P13d-1 (pure-Dart retrieval engine, "CI-covered; no APK check").[x]→[~](its children d-2a/d-2b/d-3 are still APK-owed).Changes
docs/VERIFICATION.md— replace the rough "P13 (later subphases)" placeholder with a proper "P13 — consolidated cross-feature on-device pass": the single owed gate, exercising the features together (generation stack on one model · LLM+HNSW RAM co-residency · ML Kit OCR/translate · graph analytics · gating interplay on low-tier · opt-ins persist / offline). The per-subphase rows (a–f) stay as the granular reference.docs/design/P13-PLAN.md— the marker flips above; a P13f-3 Status note; and the✅ P13 completeplaceholder replaced with an honest "code-complete; on-device verification pending" summary.docs/ROADMAP.md— one honest P13 Status line (no premature "done"); date bump.docs/BACKLOG.md— the one missing P13f-2 deferral (unify the translation language name/code sources). All other P13 deferrals were already logged per-subphase.CI / verification
dart format·flutter analyze·flutter test(940) all green locally (confirms no stray Dart change).[x]and closes the phase (→ P14).https://claude.ai/code/session_013JoYmLCosYt5tQ8qwdbL1T
Generated by Claude Code