Upgrade D3 and drop d3-tooltip#883
Merged
godlygeek merged 6 commits intobloomberg:mainfrom Mar 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
==========================================
- Coverage 92.43% 92.39% -0.04%
==========================================
Files 99 99
Lines 11707 11716 +9
Branches 426 426
==========================================
+ Hits 10821 10825 +4
- Misses 886 891 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pablogsal
approved these changes
Mar 10, 2026
The d3-tip library hasn't been maintained since 2020. Meanwhile floating-ui is the most popular library offering similar functionality. It only needs a minimal adapter to make it work with d3-flame-graph. Signed-off-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
Signed-off-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
Upgrade d3, d3-scale-chromatic and d3-flame-graph to latest versions. Signed-off-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
Signed-off-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
Signed-off-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
Signed-off-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tooltip replacement has already been approved but it targeted the wrong branch (#878). This PR incorporates those changes and upgrades D3 and other JS libraries to the latest versions.