Skip to content

Fix security-related issues in github actions flagged by zizmor#292

Open
peytondmurray wants to merge 3 commits into
bloomberg:mainfrom
peytondmurray:287-fix-zizmor-issues
Open

Fix security-related issues in github actions flagged by zizmor#292
peytondmurray wants to merge 3 commits into
bloomberg:mainfrom
peytondmurray:287-fix-zizmor-issues

Conversation

@peytondmurray
Copy link
Copy Markdown

@peytondmurray peytondmurray commented May 18, 2026

Issue number of the reported bug or feature request: Closes #287.

Describe your changes
This PR addresses a number of security-related issues in the github actions (and dependabot config) that were flagged by zizmor. Most of the changes are:

  • Pinning action versions to commit hashes
  • Disable persisting credentials in workflows after checkout
  • The default permissions are now set as conservatively as possible

This PR also adds a zizmor action to ensure these issues don't arise in the future.

Testing performed
This will be tested by running the CI in this PR.

Signed-off-by: pdmurray <peynmurray@gmail.com>
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.19%. Comparing base (debc9e8) to head (2faa7b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files          51       51           
  Lines        5542     5542           
  Branches      577      577           
=======================================
  Hits         4389     4389           
  Misses       1153     1153           
Flag Coverage Δ
cpp 79.19% <ø> (ø)
python 79.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/build_wheels.yml Outdated

container:
image: fedora
image: fedora@f717d3f59ea0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this format isn't valid and the build fails.

We chatted about this with @godlygeek and it would be good to leverage Dependabot for keeping the Docker images up to date as well. It seems it's supported.

Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray peytondmurray force-pushed the 287-fix-zizmor-issues branch from 966443b to b31d1bc Compare May 19, 2026 06:01
Signed-off-by: pdmurray <peynmurray@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix problems reported by zizmor

4 participants