Move from requirements.txt to dependency groups#296
Open
peytondmurray wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 79.19% 79.19%
=======================================
Files 51 51
Lines 5542 5542
Branches 577 577
=======================================
Hits 4389 4389
Misses 1153 1153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This change looks good to me, we just need a sign-off on the commit make the DCO check pass: https://github.com/bloomberg/pystack/actions/runs/26054143451/job/76598533415?pr=296. There are docs here on setting that up. |
Signed-off-by: pdmurray <peynmurray@gmail.com>
peytondmurray
force-pushed
the
288-dependency-groups
branch
from
e255f45 to
0f2a648
Compare
Author
|
Whoops, sorry about that! Should be signed off now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: Closes #288.
Describe your changes
This PR removes the requirements-*.txt files in favor of dependency groups.
Testing performed
Testing will be done by CI.