Skip to content

Solve #290: Fix extra blank line in pystack output #298

Open
haswee wants to merge 1 commit into
bloomberg:mainfrom
haswee:fix-290
Open

Solve #290: Fix extra blank line in pystack output #298
haswee wants to merge 1 commit into
bloomberg:mainfrom
haswee:fix-290

Conversation

@haswee
Copy link
Copy Markdown

@haswee haswee commented May 18, 2026

Signed-off-by: haswee hasweebanoth@gmail.com

*Issue number of the reported bug or feature request: #290 *

Describe your changes

yield f" {final.strip()}"
tries to strip the colored cell which fails to remove newline character in b.

Testing performed
Before the change:

root@codespaces-0213cb:/workspaces/pystack# pystack core core.4308 
Using executable found in the core file: /venv/bin/python

Core file information:
state: t zombie: True niceness: 0
pid: 4308 ppid: 4096 sid: 4096
uid: 0 gid: 0 pgrp: 4308
executable: python arguments: python

The process died due receiving signal SIGSTOP
Traceback for thread 4308 (python) [] (most recent call last):
    (Python) File "<frozen runpy>", line 198, in _run_module_as_main
    (Python) File "<frozen runpy>", line 88, in _run_code
    (Python) File "/usr/lib/python3.12/http/server.py", line 1329, in <module>
        test(

    (Python) File "/usr/lib/python3.12/http/server.py", line 1284, in test
        httpd.serve_forever()
    (Python) File "/usr/lib/python3.12/socketserver.py", line 235, in serve_forever
        ready = selector.select(poll_interval)
    (Python) File "/usr/lib/python3.12/selectors.py", line 415, in select
        fd_event_list = self._selector.poll(timeout)

After the change:

root@codespaces-0213cb:/workspaces/pystack# pystack core core.4308 
Using executable found in the core file: /venv/bin/python

Core file information:
state: t zombie: True niceness: 0
pid: 4308 ppid: 4096 sid: 4096
uid: 0 gid: 0 pgrp: 4308
executable: python arguments: python

The process died due receiving signal SIGSTOP
Traceback for thread 4308 (python) [] (most recent call last):
    (Python) File "<frozen runpy>", line 198, in _run_module_as_main
    (Python) File "<frozen runpy>", line 88, in _run_code
    (Python) File "/usr/lib/python3.12/http/server.py", line 1329, in <module>
        test(
    (Python) File "/usr/lib/python3.12/http/server.py", line 1284, in test
        httpd.serve_forever()
    (Python) File "/usr/lib/python3.12/socketserver.py", line 235, in serve_forever
        ready = selector.select(poll_interval)
    (Python) File "/usr/lib/python3.12/selectors.py", line 415, in select
        fd_event_list = self._selector.poll(timeout)

Additional context
Add any other context about your contribution here.

Signed-off-by: haswee <hasweebanoth@gmail.com>
@haswee haswee changed the title Fix extra blank line in pystack output Fix extra blank line in pystack output May 18, 2026
Copy link
Copy Markdown
Contributor

@sarahmonod sarahmonod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @haswee !

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.19%. Comparing base (debc9e8) to head (c658843).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files          51       51           
  Lines        5542     5542           
  Branches      577      577           
=======================================
  Hits         4389     4389           
  Misses       1153     1153           
Flag Coverage Δ
cpp 79.19% <100.00%> (ø)
python 79.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarahmonod sarahmonod linked an issue May 18, 2026 that may be closed by this pull request
@haswee haswee changed the title Fix extra blank line in pystack output Solve #290: Fix extra blank line in pystack output May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra blank line in pystack output

3 participants