Fix[rmqa_compressiontransformerimpl]: check compression properties#76
Merged
willhoy merged 5 commits intobloomberg:mainfrom Mar 17, 2026
Merged
Fix[rmqa_compressiontransformerimpl]: check compression properties#76willhoy merged 5 commits intobloomberg:mainfrom
willhoy merged 5 commits intobloomberg:mainfrom
Conversation
…s before use The existing implementation just checks that header exists, and it tries to just use properties from this header without checking that they actually exist. This might result in crash on assertion. Strengthen checks by verifying that the properties actually exist before use, or fail with an error. Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
Contributor
Author
thisisnsh
previously approved these changes
Mar 16, 2026
Signed-off-by: Will <2185386+willhoy@users.noreply.github.com>
willhoy
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing implementation just checks that header exists, and after this it tries to use properties from this header without checking that they actually exist. This might result in crash on assertion.
Strengthen checks by verifying that the properties actually exist before use, or fail with an error.