C: enable spelling for new language constructs (Closes #257)#258
Merged
blopker merged 1 commit intoblopker:mainfrom May 4, 2026
Merged
C: enable spelling for new language constructs (Closes #257)#258blopker merged 1 commit intoblopker:mainfrom
blopker merged 1 commit intoblopker:mainfrom
Conversation
1. Make C unit tests exhaustive for all the queries in `c.scm` (though
not necessarily a full reflection of every C language feature).
2. Add spell checking for macro functions and parameters: `#define
MACRO_FUNCTION(macro_param) macro_param + 1`.
3. Add spell checking for named unions: `union MyUnion {}`.
4. Add spell checking for array fields and variables: `int nums[20]`.
5. Made string checking more general. This change ensures that `string1`
and `string2` are both spell-checked in the example
`"string1\nstring2"`. Also string literals outside of function calls
and initializers (e.g., during assignment) also get checked.
Owner
|
Very cool. Thank you! Great test cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257.
c.scm(though not necessarily a full reflection of every C language feature).2. Add spell checking for macro functions and parameters:
#define MACRO_FUNCTION(macro_param) macro_param + 1.union MyUnion {}.int nums[20].string1andstring2are both spell-checked in the example"string1\nstring2". Also string literals outside of function calls and initializers (e.g., during assignment) also get checked.