Merged
Conversation
…ng, LanguageClient> into a single client instance. refreshClients now starts one server using workspaceFolders[0] as --root (with the existing fallback chain when there are no folders). Logs a one-line note in the Codebook output channel when a multi-root workspace is detected, calling out the first-folder limitation. stopClient replaces stopAllClients and surfaces stop errors instead of swallowing them. - editors/vscode/CHANGELOG.md — Unreleased entry pointing at #250 with the limitation note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editors/vscode/src/extension.ts — collapsed the per-folder Map<string, LanguageClient> into a single client instance. refreshClients now starts one server using workspaceFolders[0] as --root (with the existing fallback chain when there are no folders). Logs a one-line note in the Codebook output channel when a multi-root workspace is detected, calling out the first-folder limitation. stopClient replaces stopAllClients and surfaces stop errors instead of swallowing them.
editors/vscode/CHANGELOG.md — Unreleased entry pointing at [BUG]: Better multi-root workspace support in VS Code #250 with the limitation note.