Skip to content

Simplify flow w/ LINQ#1

Open
HebaruSan wants to merge 1 commit intoblowfishpro:SupportMultipleRemoteVersionsfrom
HebaruSan:feature/avc-multi-remote
Open

Simplify flow w/ LINQ#1
HebaruSan wants to merge 1 commit intoblowfishpro:SupportMultipleRemoteVersionsfrom
HebaruSan:feature/avc-multi-remote

Conversation

@HebaruSan
Copy link
Copy Markdown

Thanks for the PR! Some suggestions for the implementation...

  • When we throw, use Kraken because that's what Netkan uses otherwise
  • Don't throw if the remote version file has an array with no matches, since that should be fine
  • Gather the AvcVersion objects in one statement and process them in a uniform way regardless of format
  • Fix ancient misspelling of "preferrentially" 😁

Do these changes look OK to you?

@blowfishpro
Copy link
Copy Markdown
Owner

It looks like the exception is always going to get rescued right there anyway so the exception class doesn't actually matter does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants