Simplify flow w/ LINQ#1
Open
HebaruSan wants to merge 1 commit intoblowfishpro:SupportMultipleRemoteVersionsfrom
Open
Simplify flow w/ LINQ#1HebaruSan wants to merge 1 commit intoblowfishpro:SupportMultipleRemoteVersionsfrom
HebaruSan wants to merge 1 commit intoblowfishpro:SupportMultipleRemoteVersionsfrom
Conversation
Owner
|
It looks like the exception is always going to get rescued right there anyway so the exception class doesn't actually matter does it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the PR! Some suggestions for the implementation...
Krakenbecause that's what Netkan uses otherwiseAvcVersionobjects in one statement and process them in a uniform way regardless of formatDo these changes look OK to you?