fix: Allow user to not install Nushell in their system #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmpinder
force-pushed
the
341-feat-allow-users-to-disable-addition-of-bluebuild-and-nushell-binaries-into-image
branch
from
907981d to
c4421fe
Compare
xynydev
approved these changes
Feb 25, 2025
gmpinder
deleted the
341-feat-allow-users-to-disable-addition-of-bluebuild-and-nushell-binaries-into-image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow our users to set
nushell-versionandblue-build-tagto the value ofnoneto prevent the binaries from being added to the image. Since we have multiple modules that will be using nushell, I made sure to mount the nushell binaries into the image if the value is set tonone.