Skip to content

Conversation

@gmpinder
Copy link
Member

No description provided.

@gmpinder gmpinder added the type: docs Related to documentation and information. label Apr 26, 2024
@gmpinder gmpinder self-assigned this Apr 26, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 26, 2024

Deploying bluebuild-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 944397f
Status: ✅  Deploy successful!
Preview URL: https://37d1b743.website-18h.pages.dev
Branch Preview URL: https://receipes-dir-docs-update.website-18h.pages.dev

View logs

@gmpinder gmpinder marked this pull request as draft April 26, 2024 20:41
@gmpinder gmpinder marked this pull request as ready for review April 26, 2024 22:03
@gmpinder gmpinder changed the title chore: Update docs to reflect use of ./recipes/ directory chore: Update docs to reflect use of ./recipes/ directory and create blog post Apr 26, 2024
@gmpinder
Copy link
Member Author

Not sure what I did, but the build seems to not be happy with the new blog post.

Copy link
Member

@xynydev xynydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jerry! ^^

It's looking good, but I'll give you some comments. I think that with this release we should be clear to release the recipe folder refactor, and discuss more on the config/ folder.

Copy link
Member

@xynydev xynydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there should also be some changes in the previous blog post / migration guide telling people to move their recipe files over. https://blue-build.org/blog/introducing-bluebuild/#upgrade-your-current-repository-recommended

gmpinder and others added 4 commits April 27, 2024 09:13
Co-authored-by: xyny <60004820+xynydev@users.noreply.github.com>
Co-authored-by: xyny <60004820+xynydev@users.noreply.github.com>
Co-authored-by: xyny <60004820+xynydev@users.noreply.github.com>
Co-authored-by: xyny <60004820+xynydev@users.noreply.github.com>
@gmpinder
Copy link
Member Author

Maybe there should also be some changes in the previous blog post / migration guide telling people to move their recipe files over. https://blue-build.org/blog/introducing-bluebuild/#upgrade-your-current-repository-recommended

Lol I actually made changes to that not realizing it was a blog post, then removed the changes cause I didn't want to edit the past. I'll put it back.

@gmpinder
Copy link
Member Author

This blog post is looking good!

@fiftydinar
Copy link
Contributor

Since there is a critical fix for parsing YAMLs in CLI & close-to-critical fix for akmods, we can merge those changes now, while work on migrating from ./config to ./files & ./containerfiles can come later, where we would announce another blogpost.

Or perhaps, do the quick work on ./config migration too & update this blogpost?

What are your opinions?

@gmpinder
Copy link
Member Author

Since there is a critical fix for parsing YAMLs in CLI & close-to-critical fix for akmods, we can merge those changes now, while work on migrating from ./config to ./files & ./containerfiles can come later, where we would announce another blogpost.

Or perhaps, do the quick work on ./config migration too & update this blogpost?

What are your opinions?

I'd like to get these changes released sooner. All the ./recipes/ changes are done and merged except this update to the website. This can be done completely separate from the ./config/ to ./files/ migration. I don't think holding back this important feature for a cosmetic change is the right course of action.

@fiftydinar
Copy link
Contributor

I'd like to get these changes released sooner. All the ./recipes/ changes are done and merged except this update to the website. This can be done completely separate from the ./config/ to ./files/ migration. I don't think holding back this important feature for a cosmetic change is the right course of action.

I agree on this one.

@xynydev xynydev merged commit 8904e8e into main May 1, 2024
@xynydev xynydev deleted the receipes-dir-docs-update branch May 1, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: docs Related to documentation and information.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants