CUDA & CPU: support incontiguous inputs for get_rel_pos #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_pos * Removed the overridden max_nmse_err method in the test_get_rel_pos struct as it was deemed unnecessary. * Added multiple new test cases for various attention configurations, enhancing coverage for the get_rel_pos functionality.
…ML_OP_GET_REL_POS
Author
|
Test results of 
|
Owner
|
@AgainstEntropy Please take a look at the error message for the failures and feel free to tell me what I can help you. |
Author
Seems the error was raised from this line: llama.cpp/ggml/src/ggml-cuda/win.cu Line 141 in 4813779 I think we should be able to fix it by replacing the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.