fix: only mark VinylCache Ready when all replicas have VCL#25
Merged
Conversation
The operator was marking VinylCache as Ready after pushing VCL to any available pods, without checking that all requested replicas were up. This caused all multi-replica E2E tests to fail. Changes: - calculatePhase: require ReadyPeers >= TotalPeers for PhaseReady - updateStatus: set VCLSynced=False and Progressing=True when partial - Reconciler: requeue after 5s when not all replicas ready (vs 5min) Fixes #24 Refs #20 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jensens
force-pushed
the
fix/multi-replica-readiness
branch
from
147ebb6 to
bf65be0
Compare
The CI workflow was building the agent binary as cloud-vinyl-varnish:dev (wrong name) and never loading a real varnish image. The install script also never passed the agent image to Helm, so the operator defaulted to cloud-vinyl-agent:<appVersion> which didn't exist in Kind. Fixes: - Build agent as cloud-vinyl-agent:dev (correct name) - Pull and tag stock varnish:7.6 as cloud-vinyl-varnish:dev - Pass AGENT_IMAGE to Helm via install-operator.sh Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There is no custom cloud-vinyl-varnish image — use stock varnish:7.6 directly in test fixtures. Pre-pull into Kind so pods don't need to fetch from Docker Hub during tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The operator was marking VinylCache as
Ready=Trueafter pushing VCL to any available pods, without verifying all requested replicas were up. This caused all multi-replica E2E tests to fail (#20).Changes
calculatePhase(): RequireReadyPeers >= TotalPeersforPhaseReadyupdateStatus(): SetVCLSynced=False+Progressing=Truewhen only partial replicas have VCLBefore
After
Fixes #24
Refs #20
Test plan
go test ./internal/controller/...)go build ./...clean🤖 Generated with Claude Code