Skip to content

Return on io error to prevent misleading error message #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rayozzie merged 1 commit into from
Sep 7, 2023
Merged

Return on io error to prevent misleading error message #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions notecard/dfu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ func dfuSideload(filename string, verbose bool) (err error) {
binaryMax := 0
var rsp notecard.Request
rsp, err = card.TransactionRequest(notecard.Request{Req: "card.binary"})
if note.ErrorContains(err, note.ErrCardIo) {
return err
}

if err == nil {

// Get the maximum size that the notecard can handle
Expand Down