Disable BlurView on android #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue is also affecting the profile editor on android |
pfrazee
changed the title
|
This bug is also affecting the register page, but it happened on my iPhone 11 |
This was referenced Dec 28, 2023
estrattonbailey
approved these changes
Dec 28, 2023
estrattonbailey
added a commit
that referenced
this pull request
Jan 1, 2024
* origin/main: (67 commits) Localize options in "Thread Preferences" screen (#2373) Bump ios build number and android version code Remove the KeyboardAvoidingView in account creation (close #2333) (#2366) 1.62 Create account tweaks (#2365) Fix sizing of the leftnav new post btn (#2248) Use memory caching for android lightbox (#2354) Disable page-transition animations on android (#2352) Disable BlurView on android (#2351) Handle birth dates as UTC, handle locale formatting (#2363) Fix desktop styles a bit Disable spanish translation until it's more thoroughly reviewed (#2362) minor search screen ux improvements (#2264) Temporarily disable the german translation (#2360) Web dropdowns (#2358) Mark more text as translatable (#2284) Remove patched color scheme code (#2340) support multiple og:image tags (#2305) Fix missing avatar moderation in replies (#2325) Fixes to feed load triggers (#2323) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something is horribly wrong here.
We've had various reports from users that a
<TextInput>will drop user input. Then we got #2344 reported, which gave us two lucky breaks:With the repro I massively struggled to figure out the cause of this. Here are all of the bizarre behaviors:
onChangefires and the value is updated and the correct string is passed into the<TextInput>.<CharCounter>wasn't updating either.I tested a variety of possible causes. I pulled out everything to do with BottomSheet. I removed all properties on the
<TextInput>. I turned off autocomplete, autocorrect, etc. I also googled this aggressively and tried a variety of known hackfixes. None of this had any effect.The
<CharCounter>failing to update despite the value changing was the final clue. That led me to do 569ce38 which simply sets akeyon any component in the render tree, and bizarrely that fixed both of the problems.What this suggests to me is that somehow the render is failing to make its way through the react/react-native pipeline. I have absolutely no idea how that could be happening.
UPDATE
My god. I kept digging after this and discovered that running a
setIntervalin the header of a profile would show similar characteristics -- the UI would just stop updating -- but in the header of the home screen this didn't happen. Then I noticed that scrolling down a little bit in the profile fix this problem entirely.Turns out, the
@react-native-community/blur<BlurView>being used for the background of the back button was to blame. As soon as that was out of view, everything worked fine.I need a drink.