Remove the KeyboardAvoidingView in account creation (close #2333) #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
added a commit
that referenced
this pull request
Jan 1, 2024
* origin/main: (67 commits) Localize options in "Thread Preferences" screen (#2373) Bump ios build number and android version code Remove the KeyboardAvoidingView in account creation (close #2333) (#2366) 1.62 Create account tweaks (#2365) Fix sizing of the leftnav new post btn (#2248) Use memory caching for android lightbox (#2354) Disable page-transition animations on android (#2352) Disable BlurView on android (#2351) Handle birth dates as UTC, handle locale formatting (#2363) Fix desktop styles a bit Disable spanish translation until it's more thoroughly reviewed (#2362) minor search screen ux improvements (#2264) Temporarily disable the german translation (#2360) Web dropdowns (#2358) Mark more text as translatable (#2284) Remove patched color scheme code (#2340) support multiple og:image tags (#2305) Fix missing avatar moderation in replies (#2325) Fixes to feed load triggers (#2323) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2333
No idea why, but for some reason the
<KeyboardAvoidingView>is triggering a UI freeze on iOS prod only. This is quite unfortunate because it breaks account creation. I checked the other places it's used and no freeze seems to occur, so there's something about the create-account UI specifically that experiences this.This PR removes it and just puts a pad at the bottom of the screen. Tested on iOS (on device), Web, and Android (simulator).