Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reduced Onboarding] Fix forward/backward nav with profile step #3997

Merged
merged 3 commits into from
May 13, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented May 13, 2024

Initially made this work with the image, but realized when adding metrics that it didn't work for created avatars. This PR ensures that whatever your last choice was, it retains that state when navigating forward and backward through onboarding.

Lint error fixed in #3999, will merge that into this before merging into main.

Copy link

render bot commented May 13, 2024

Copy link

github-actions bot commented May 13, 2024

Old size New size Diff
7.15 MB 7.15 MB 474 B (0.01%)

* Add prop to finished event

* Fix type

* Use separate event
@estrattonbailey estrattonbailey merged commit 95514e3 into main May 13, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request May 14, 2024
* origin/main:
  [🐴] Make status checks easier, fix load state (#4010)
  [🐴] Chat muted state (#3988)
  [🐴] Swap in new package, update usages (#3992)
  Add better onboard testing (#4007)
  add a `Login` notifications request (#4006)
  align the trash icon in the center in feed edit list (#4004)
  Make feeds easier to reorder (#3998)
  [Reduced Onboarding] Fix forward/backward nav with profile step (#3997)
  Gate base following feed usage (#3994)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants