Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐴] Chat muted state #3988

Merged
merged 2 commits into from
May 14, 2024
Merged

[🐴] Chat muted state #3988

merged 2 commits into from
May 14, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented May 13, 2024

Screenshot 2024-05-13 at 19 31 28

Copy link

render bot commented May 13, 2024

Copy link

Old size New size Diff
7.15 MB 7.15 MB 1.72 KB (0.02%)

@danninov
Copy link
Contributor

danninov commented May 13, 2024

IMHO, it's better to have the mute icon on most right side. First, it'll have consistency: account name - time - mute/other icon. Second, some people put emoji on their account name, which make it confusing if it has side by side.

@mozzius
Copy link
Member Author

mozzius commented May 13, 2024

IMHO, it's better to have the mute icon on most right side. First, it'll have consistency: account name - time - mute/other icon. Second, some people put emoji on their account name, which make it confusing if it has side by side.

good idea!

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Bell alignment looks just a hair high though CleanShot 2024-05-14 at 09 27 00@2x

@mozzius
Copy link
Member Author

mozzius commented May 14, 2024

What platform is that?

@estrattonbailey
Copy link
Member

Web. Ya know what, I think it's centered, but next to the 6m and low x-height of the m it looks high 🤔

@mozzius mozzius merged commit bffb9b5 into main May 14, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request May 14, 2024
* origin/main:
  [🐴] Make status checks easier, fix load state (#4010)
  [🐴] Chat muted state (#3988)
  [🐴] Swap in new package, update usages (#3992)
  Add better onboard testing (#4007)
  add a `Login` notifications request (#4006)
  align the trash icon in the center in feed edit list (#4004)
  Make feeds easier to reorder (#3998)
  [Reduced Onboarding] Fix forward/backward nav with profile step (#3997)
  Gate base following feed usage (#3994)
estrattonbailey added a commit that referenced this pull request May 15, 2024
* origin/main: (48 commits)
  [🐴] Show if user can be messaged in new chat search (#4021)
  Make more localizable (#3962)
  [🐴] change `Follows Only` to `People I Follow` (#4028)
  Reset after 5 min (#4026)
  [🐴] Block states, read only (#4022)
  [🐴]Add DM push notification sound (#4000)
  remove serviceurl gate (#4019)
  reword subtitle (#4017)
  [🐴] show deleted account for `missing.invalid` (#4014)
  [🐴] use "Chats" instead of "Messages" (#4013)
  100vh settings screen (#4015)
  Run intl extract (#4016)
  [🐴] Settings screen (#3830)
  [🐴] Message drafts (#3993)
  Update Korean localization (#3887)
  Update catalan messages.po (#3984)
  Fix dep (#4011)
  [🐴] Make status checks easier, fix load state (#4010)
  [🐴] Chat muted state (#3988)
  [🐴] Swap in new package, update usages (#3992)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants