[🐴] Make status checks easier, fix load state #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4010.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp1omd63e1ms73b4g510. |
haileyok
approved these changes
May 14, 2024
|
estrattonbailey
added a commit
that referenced
this pull request
May 14, 2024
* origin/main: [🐴] Make status checks easier, fix load state (#4010) [🐴] Chat muted state (#3988) [🐴] Swap in new package, update usages (#3992) Add better onboard testing (#4007) add a `Login` notifications request (#4006) align the trash icon in the center in feed edit list (#4004) Make feeds easier to reorder (#3998) [Reduced Onboarding] Fix forward/backward nav with profile step (#3997) Gate base following feed usage (#3994)
estrattonbailey
added a commit
that referenced
this pull request
May 15, 2024
* origin/main: (48 commits) [🐴] Show if user can be messaged in new chat search (#4021) Make more localizable (#3962) [🐴] change `Follows Only` to `People I Follow` (#4028) Reset after 5 min (#4026) [🐴] Block states, read only (#4022) [🐴]Add DM push notification sound (#4000) remove serviceurl gate (#4019) reword subtitle (#4017) [🐴] show deleted account for `missing.invalid` (#4014) [🐴] use "Chats" instead of "Messages" (#4013) 100vh settings screen (#4015) Run intl extract (#4016) [🐴] Settings screen (#3830) [🐴] Message drafts (#3993) Update Korean localization (#3887) Update catalan messages.po (#3984) Fix dep (#4011) [🐴] Make status checks easier, fix load state (#4010) [🐴] Chat muted state (#3988) [🐴] Swap in new package, update usages (#3992) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the goals of the
Convoagent is to help prevent invalid states and invalid prop access. This PR adds a couple utils to help with this:isConvoActive— checks if theConvois in an activestatususeConvoActive— provides assurance thatisConvoActive(convo)is trueThis helps when creating UI, so that we don't always need to check
Convo.status, and with load states for the same reason.See below where the convo no longer re-initializes when backgrounded.
RocketSim_Recording_iPhone_15_6.1_2024-05-14_11.03.31.mp4