[🐴] Fix delete message error #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4065.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp381rmct0pc73eldjf0. |
|
haileyok
approved these changes
May 16, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 17, 2024
* origin/main: [🐴] Don't always show notification for everything (#4083) [🐴] Additional tweaks to the message list (#4075) Conditionally load unreads (#4072) Revert "Aggregate quickly-sent messages into batches (#4061)" (#4069) 100% Real Deal™ (#4070) [🐴] 60 FPS Keyboard (#4066) Fix delete message error (#4065) Aggregate quickly-sent messages into batches (#4061) [🐴] Input hover and focus styles (#4064) fix typo (#4060) Fix error styles (#4063) Reset leave chat optimistic update if fails (#4058) don't show individual labels on own profile, only "have been placed..." (#4057) [🐴] Tweak header styles (#4053)
estrattonbailey
added a commit
that referenced
this pull request
May 17, 2024
* origin/main: [🐴] NUX (#4062) [🐴] Reduce header size (#4078) [🐴] Don't always show notification for everything (#4083) [🐴] Additional tweaks to the message list (#4075) Conditionally load unreads (#4072) Revert "Aggregate quickly-sent messages into batches (#4061)" (#4069) 100% Real Deal™ (#4070) [🐴] 60 FPS Keyboard (#4066) Fix delete message error (#4065) Aggregate quickly-sent messages into batches (#4061) [🐴] Input hover and focus styles (#4064) fix typo (#4060) Fix error styles (#4063) Reset leave chat optimistic update if fails (#4058) don't show individual labels on own profile, only "have been placed..." (#4057) [🐴] Tweak header styles (#4053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some competing optimistic stuff here. Deleting a message would immediately hide (handled in
Convo) but then we tried to open a retry prompt from theMessageMenu. To keep it simple, let's just show a toast that it failed. The deleted message will be re-inserted if it fails inConvo.